FindBugs Results

The following document contains the results of FindBugs.

Summary

FilesErrors
1734

Files

FilesViolations
uk.ac.roe.antigen.ant.BuildGrabber 6
uk.ac.roe.antigen.builder.Installer 5
uk.ac.roe.antigen.dialogs.AbstractFilePropertyInputHandler 1
uk.ac.roe.antigen.dialogs.DirPropertyInputHandler 1
uk.ac.roe.antigen.dialogs.FilePropertyInputHandler 1
uk.ac.roe.antigen.dialogs.InfoFrame 1
uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler 3
uk.ac.roe.antigen.dialogs.TargetChoiceFrame 2
uk.ac.roe.antigen.dialogs.TextPropertyInputHandler 2
uk.ac.roe.antigen.textcomponents.TextTargetChooser 2
uk.ac.roe.antigen.utils.BrowserLauncher 2
uk.ac.roe.antigen.utils.Config 1
uk.ac.roe.antigen.utils.CopyableFile 3
uk.ac.roe.antigen.ant.TaskTreeCalcuator 1
uk.ac.roe.antigen.dialogs.AntigenFrame$1 1
uk.ac.roe.antigen.dialogs.TargetChoiceFrame$TaskDescription 1
uk.ac.roe.antigen.textcomponents.TextTargetChooser$TaskDescription 1

uk.ac.roe.antigen.ant.BuildGrabber

ViolationLine
RV: uk.ac.roe.antigen.ant.BuildGrabber.grab(java.util.jar.JarFile) ignores return value of java.io.File.createNewFile() 109
OS: uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) may fail to close stream 180
OS: uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) may fail to close stream on exception 211
DLS: Dead store to local variable in method uk.ac.roe.antigen.ant.BuildGrabber.main(String[]) 45
DLS: Dead store to local variable in method uk.ac.roe.antigen.ant.BuildGrabber.copyStreams(java.io.InputStream,java.io.OutputStream) 121
REC: Method uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 223

uk.ac.roe.antigen.builder.Installer

ViolationLine
UI: Usage of GetResource in uk.ac.roe.antigen.builder.Installer.getEnclosingJar() may be unsafe if class is extended 464
Dm: uk.ac.roe.antigen.builder.Installer.parseCommandLine(String[]) invokes System.exit(...), which shuts down the entire virtual machine 403
Dm: uk.ac.roe.antigen.builder.Installer.parseCommandLine(String[]) invokes System.exit(...), which shuts down the entire virtual machine 407
DLS: Dead store to local variable in method uk.ac.roe.antigen.builder.Installer.main(String[]) 300
DLS: Dead store to local variable in method uk.ac.roe.antigen.builder.Installer.getEnclosingJar() 467

uk.ac.roe.antigen.dialogs.AbstractFilePropertyInputHandler

ViolationLine
REC: Method uk.ac.roe.antigen.dialogs.AbstractFilePropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 143

uk.ac.roe.antigen.dialogs.DirPropertyInputHandler

ViolationLine
SW: Call to swing method in uk.ac.roe.antigen.dialogs.DirPropertyInputHandler.main(String[]) needs to be performed in Swing event thread 36

uk.ac.roe.antigen.dialogs.FilePropertyInputHandler

ViolationLine
SW: Call to swing method in uk.ac.roe.antigen.dialogs.FilePropertyInputHandler.main(String[]) needs to be performed in Swing event thread 35

uk.ac.roe.antigen.dialogs.InfoFrame

ViolationLine
REC: Method uk.ac.roe.antigen.dialogs.InfoFrame.initGUI2() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 111

uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler

ViolationLine
SW: Call to swing method in uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.main(String[]) needs to be performed in Swing event thread 60
REC: Method uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 149
BC: Unchecked/unconfirmed cast from org.apache.tools.ant.input.InputRequest to class org.apache.tools.ant.input.MultipleChoiceInputRequest in uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.handleInput(org.apache.tools.ant.input.InputRequest) 164

uk.ac.roe.antigen.dialogs.TargetChoiceFrame

ViolationLine
MF: Class uk.ac.roe.antigen.dialogs.TargetChoiceFrame defines field that obscures superclass field uk.ac.roe.antigen.dialogs.AntigenFrame.jLabel1 0
REC: Method uk.ac.roe.antigen.dialogs.TargetChoiceFrame.initGUI2() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 163

uk.ac.roe.antigen.dialogs.TextPropertyInputHandler

ViolationLine
SW: Call to swing method in uk.ac.roe.antigen.dialogs.TextPropertyInputHandler.main(String[]) needs to be performed in Swing event thread 45
REC: Method uk.ac.roe.antigen.dialogs.TextPropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 131

uk.ac.roe.antigen.textcomponents.TextTargetChooser

ViolationLine
NP: Immediate dereference of the result of readLine() in uk.ac.roe.antigen.textcomponents.TextTargetChooser.showAndWaitForResponse() 176
NP: Possible null pointer returned by method could be dereferenced uk.ac.roe.antigen.textcomponents.TextTargetChooser.showAndWaitForResponse() 176

uk.ac.roe.antigen.utils.BrowserLauncher

ViolationLine
FE: Test for floating point equality in uk.ac.roe.antigen.utils.BrowserLauncher.<clinit>(). 208
FE: Test for floating point equality in uk.ac.roe.antigen.utils.BrowserLauncher.<clinit>(). 215

uk.ac.roe.antigen.utils.Config

ViolationLine
ES: Comparison of String objects using == or != in uk.ac.roe.antigen.utils.Config.getProperty(String) 38

uk.ac.roe.antigen.utils.CopyableFile

ViolationLine
SnVI: uk.ac.roe.antigen.utils.CopyableFile is Serializable; consider declaring a serialVersionUID 0
OS: uk.ac.roe.antigen.utils.CopyableFile.copyFileTo(java.io.File) may fail to close stream 92
OS: uk.ac.roe.antigen.utils.CopyableFile.copyFileTo(java.io.File) may fail to close stream 94

uk.ac.roe.antigen.ant.TaskTreeCalcuator

ViolationLine
UrF: Unread field: uk.ac.roe.antigen.ant.TaskTreeCalcuator.namesToTargets 0

uk.ac.roe.antigen.dialogs.AntigenFrame$1

ViolationLine
SIC: The class uk.ac.roe.antigen.dialogs.AntigenFrame$1 could be refactored into a named _static_ inner class 0

uk.ac.roe.antigen.dialogs.TargetChoiceFrame$TaskDescription

ViolationLine
SIC: Should uk.ac.roe.antigen.dialogs.TargetChoiceFrame$TaskDescription be a _static_ inner class? 0

uk.ac.roe.antigen.textcomponents.TextTargetChooser$TaskDescription

ViolationLine
SIC: Should uk.ac.roe.antigen.textcomponents.TextTargetChooser$TaskDescription be a _static_ inner class? 0