Violation | Line |
---|---|
RV: uk.ac.roe.antigen.ant.BuildGrabber.grab(java.util.jar.JarFile) ignores return value of java.io.File.createNewFile() | 109 |
OS: uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) may fail to close stream | 180 |
OS: uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) may fail to close stream on exception | 211 |
DLS: Dead store to local variable in method uk.ac.roe.antigen.ant.BuildGrabber.main(String[]) | 45 |
DLS: Dead store to local variable in method uk.ac.roe.antigen.ant.BuildGrabber.copyStreams(java.io.InputStream,java.io.OutputStream) | 121 |
REC: Method uk.ac.roe.antigen.ant.BuildGrabber.unzipFile(String,java.util.jar.JarFile,java.io.File,boolean) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 223 |
Violation | Line |
---|---|
UI: Usage of GetResource in uk.ac.roe.antigen.builder.Installer.getEnclosingJar() may be unsafe if class is extended | 464 |
Dm: uk.ac.roe.antigen.builder.Installer.parseCommandLine(String[]) invokes System.exit(...), which shuts down the entire virtual machine | 403 |
Dm: uk.ac.roe.antigen.builder.Installer.parseCommandLine(String[]) invokes System.exit(...), which shuts down the entire virtual machine | 407 |
DLS: Dead store to local variable in method uk.ac.roe.antigen.builder.Installer.main(String[]) | 300 |
DLS: Dead store to local variable in method uk.ac.roe.antigen.builder.Installer.getEnclosingJar() | 467 |
Violation | Line |
---|---|
REC: Method uk.ac.roe.antigen.dialogs.AbstractFilePropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 143 |
Violation | Line |
---|---|
SW: Call to swing method in uk.ac.roe.antigen.dialogs.DirPropertyInputHandler.main(String[]) needs to be performed in Swing event thread | 36 |
Violation | Line |
---|---|
SW: Call to swing method in uk.ac.roe.antigen.dialogs.FilePropertyInputHandler.main(String[]) needs to be performed in Swing event thread | 35 |
Violation | Line |
---|---|
REC: Method uk.ac.roe.antigen.dialogs.InfoFrame.initGUI2() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 111 |
Violation | Line |
---|---|
SW: Call to swing method in uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.main(String[]) needs to be performed in Swing event thread | 60 |
REC: Method uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 149 |
BC: Unchecked/unconfirmed cast from org.apache.tools.ant.input.InputRequest to class org.apache.tools.ant.input.MultipleChoiceInputRequest in uk.ac.roe.antigen.dialogs.RadioPropertyInputHandler.handleInput(org.apache.tools.ant.input.InputRequest) | 164 |
Violation | Line |
---|---|
MF: Class uk.ac.roe.antigen.dialogs.TargetChoiceFrame defines field that obscures superclass field uk.ac.roe.antigen.dialogs.AntigenFrame.jLabel1 | 0 |
REC: Method uk.ac.roe.antigen.dialogs.TargetChoiceFrame.initGUI2() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 163 |
Violation | Line |
---|---|
SW: Call to swing method in uk.ac.roe.antigen.dialogs.TextPropertyInputHandler.main(String[]) needs to be performed in Swing event thread | 45 |
REC: Method uk.ac.roe.antigen.dialogs.TextPropertyInputHandler.initGUI() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 131 |
Violation | Line |
---|---|
NP: Immediate dereference of the result of readLine() in uk.ac.roe.antigen.textcomponents.TextTargetChooser.showAndWaitForResponse() | 176 |
NP: Possible null pointer returned by method could be dereferenced uk.ac.roe.antigen.textcomponents.TextTargetChooser.showAndWaitForResponse() | 176 |
Violation | Line |
---|---|
FE: Test for floating point equality in uk.ac.roe.antigen.utils.BrowserLauncher.<clinit>(). | 208 |
FE: Test for floating point equality in uk.ac.roe.antigen.utils.BrowserLauncher.<clinit>(). | 215 |
Violation | Line |
---|---|
ES: Comparison of String objects using == or != in uk.ac.roe.antigen.utils.Config.getProperty(String) | 38 |
Violation | Line |
---|---|
SnVI: uk.ac.roe.antigen.utils.CopyableFile is Serializable; consider declaring a serialVersionUID | 0 |
OS: uk.ac.roe.antigen.utils.CopyableFile.copyFileTo(java.io.File) may fail to close stream | 92 |
OS: uk.ac.roe.antigen.utils.CopyableFile.copyFileTo(java.io.File) may fail to close stream | 94 |
Violation | Line |
---|---|
UrF: Unread field: uk.ac.roe.antigen.ant.TaskTreeCalcuator.namesToTargets | 0 |
Violation | Line |
---|---|
SIC: The class uk.ac.roe.antigen.dialogs.AntigenFrame$1 could be refactored into a named _static_ inner class | 0 |
Violation | Line |
---|---|
SIC: Should uk.ac.roe.antigen.dialogs.TargetChoiceFrame$TaskDescription be a _static_ inner class? | 0 |
Violation | Line |
---|---|
SIC: Should uk.ac.roe.antigen.textcomponents.TextTargetChooser$TaskDescription be a _static_ inner class? | 0 |